Open
Conversation
Doc94
reviewed
Apr 23, 2026
Owen1212055
reviewed
Apr 23, 2026
Doc94
reviewed
Apr 23, 2026
Member
|
Clocks items are still broken. 2026-04-23_12-08-24.mp4this was tested in a new world, the main world the item works. |
Doc94
reviewed
Apr 23, 2026
| + | ||
| + public float partialTick(final Holder<WorldClock> definition) { | ||
| + return this.getInstance(definition).partialTick; | ||
| + public ClientboundSetTimePacket createFullSyncPacket(final net.minecraft.server.level.ServerPlayer player) { |
Member
There was a problem hiding this comment.
This need to be marked Nullable, same with packNetworkState with the null player
Member
Author
There was a problem hiding this comment.
The lines were too long so I skipped it 🛏️
Member
Author
They're hardcoded to only work in the overworld level |
Contributor
|
A resource pack would be needed to make them work in a custom world with a custom item model definition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes clock managers per-world, given clocks have to be put into client-synchronized registries, which is a big no no and unnecessary block for creating worlds on the fly
Splits TimeSkipEvent into a new ClockTimeSkipEvent for when the new config option is toggled to make clocks global again. the actual clock API will be added separately. the time command succeeds even if the event is cancelled (as before?), but that didn't look like something to waste time on
Tested by creating new worlds / switching worlds with per-player time set and/or paused