Improving readability of progress bar#2584
Open
erikvansebille wants to merge 3 commits intoParcels-code:mainfrom
Open
Improving readability of progress bar#2584erikvansebille wants to merge 3 commits intoParcels-code:mainfrom
erikvansebille wants to merge 3 commits intoParcels-code:mainfrom
Conversation
Member
Author
|
Perhaps we should change "Integration time" to "Simulation time" or simply "Time" or "Progress"? |
Member
|
I quite liked the 554400.0 / 2678400.0 like information. If my simulation crashed, I could tell immediately from the log at what timestep to investigate. Could this be a toggle-able run-time option (like the rcParams in matplotlib)? |
Member
Author
But can't you use the datetime itself for that? That is in front of the progress bar and is also updated. What does the time counter have that the datetime doesn't? |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the readability of the
tqdmprogress bar byBefore

After

Note: I'm not sure how to write unit tests for this; and whether that is even necessary
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure