Skip to content

RabbitMQ: Only set the AuthMechanisms when UseExternalAuthMechanism is set to true #5416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielmarbach merged 1 commit into from
Apr 13, 2026
+1 −2
Merged

RabbitMQ: Only set the AuthMechanisms when UseExternalAuthMechanism is set to true #5416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/ServiceControl.Transports.RabbitMQ/RabbitMQTransportExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,8 @@ public static void ApplySettingsFromConnectionString(this RabbitMQTransport tran
transport.ValidateRemoteCertificate = !disableRemoteCertificateValidation;
}

if (dictionary.TryGetValue("UseExternalAuthMechanism", out var useExternalAuthMechanismString))
if (dictionary.TryGetValue("UseExternalAuthMechanism", out var useExternalAuthMechanismString) && bool.TryParse(useExternalAuthMechanismString, out var useExternalAuthMechanism) && useExternalAuthMechanism)
Copy link
Copy Markdown
Member

@ramonsmits ramonsmits Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If parsing fails, there should be an exception as that means there was a typo unless the values in the dictionary have already been format validated.

Copy link
Copy Markdown
Contributor Author

@danielmarbach danielmarbach Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the code uses TryParse too. I'm trying to make a minimal fix here.

{
_ = bool.TryParse(useExternalAuthMechanismString, out var useExternalAuthMechanism);
transport.AuthMechanisms = [new ExternalMechanismFactory()];
}
}
Expand Down