Imbued Support Selection Improvements#9786
Draft
Peechey wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Draft
Imbued Support Selection Improvements#9786Peechey wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Peechey wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
…ean up imbued after fully backspacing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Draft for now. Fixing up the Imbued GemSelect to process only when the buffer matches a gem name rather than always running the code for the gem at index 1 in the search list for every single change to the buf. The imbued will only be added if you: 1) click the gem 2) type the name out entirely or 3) use the arrows to select one from the list. If you have an imbued and then backspace, we would now only run the cycle once to remove the imbued as it doesn't match anymore. Simple rule is one cycle per match/un-match, not one cycle per changeFunc call/buf change.
I would like to do this for the other GemSelects but the changeFunction and structure of those are not the same and it's proving difficult.
Steps taken to verify a working solution:
There are a couple different states to keep in mind:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: