Replace cat_tools--0.2.0--0.2.1.sql with rebuilt .sql.in#15
Merged
jnasbyupgrade merged 3 commits intomasterfrom Apr 20, 2026
Merged
Replace cat_tools--0.2.0--0.2.1.sql with rebuilt .sql.in#15jnasbyupgrade merged 3 commits intomasterfrom
jnasbyupgrade merged 3 commits intomasterfrom
Conversation
The committed .sql was generated for PG 9.3-9.4 only: REQUIRES 9.5! markers were manually pre-processed (commented out) while PRIOR TO 9.5! counterparts were missing entirely, causing silent installation of the wrong return types and extschema column on PG >= 9.5. Rebuild from the diff of cat_tools.sql.in between 0.2.0 and 0.2.1: - pg_extension_v, pg_extension__get, extension__schemas/unique (name[] and text overloads) with correct REQUIRES/PRIOR TO 9.5 SED markers - trigger__get_oid__loose: smarter tgname quote-stripping - trigger__get_oid: proper errcode on exception - trigger__parse(oid): DROP + recreate with new OUT params (trigger_table, trigger_function; function_arguments text -> text[]) - trigger__parse(regclass, text): new overload - trigger__args_as_text: new backwards-compat helper - object__reg_type_catalog: fix hint URL Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
base.mk already adds sql/*--*--*.sql via wildcard; adding them again via versioned_out caused a duplicate-file error in make install. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jnasbyupgrade
force-pushed
the
rebuild-0.2.0-0.2.1-upgrade
branch
from
ff61d3c to
197befa
Compare
The old name was confusing — upgrade scripts are "versioned" by definition. upgrade_scripts_out is clearer about what the variable represents. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The committed
cat_tools--0.2.0--0.2.1.sqlwas generated for PG 9.3–9.4 only. The-- SED: REQUIRES 9.5!markers were manually pre-processed (commented out) but the-- SED: PRIOR TO 9.5!counterpart lines were never added. On PG ≥ 9.5 this silently installs:extension__schemas/extension__schemas_unique(name[]instead ofregnamespace[])extschemacolumn inpg_extension_v(nspnameinstead ofextnamespace::regnamespace)Fix
Replace with a proper
.sql.in, rebuilt from the diff ofcat_tools.sql.inbetween 0.2.0 and 0.2.1. Contains only the actual delta (not a full install script copy-paste):pg_extension_vview — correctREQUIRES/PRIOR TO 9.5SED marker pairpg_extension__get,extension__schemas/unique(name[] + text overloads) — correct SED markers for return typetrigger__get_oid__loose— smarter tgname quote-strippingtrigger__get_oid— propererrcodeon exceptiontrigger__parse(oid)— DROP + recreate with new OUT params (trigger_table,trigger_function;function_arguments text → text[])trigger__parse(regclass, text)— new overloadtrigger__args_as_text— new backwards-compat helperobject__reg_type_catalog— fix hint URL🤖 Generated with Claude Code