Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
The canvas module is a server-side dependency used by prismarine-viewer (in entities.js and atlas.js). In browser builds, the native Canvas API is available instead. Adding canvas: false to webpack aliases prevents the "Module not found: Error: Can't resolve 'canvas'" build failure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rom1504
commented
Mar 30, 2026
| jose: false, | ||
| '@azure/msal-node': false | ||
| '@azure/msal-node': false, | ||
| canvas: false |
There was a problem hiding this comment.
With Node 24, the canvas native addon (an optional dependency of prismarine-viewer) no longer installs successfully, so it's absent from node_modules. This caused webpack to fail with Can't resolve 'canvas' when bundling prismarine-viewer/viewer/lib/entities.js line 7.
Setting canvas: false stubs out require('canvas') as false for the browser bundle. In browser environments, the code falls back to the native HTMLCanvasElement API (document.createElement('canvas')) rather than the npm canvas package — the npm package is only needed for server-side (Node.js) canvas rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Claude Code