You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SimModSuite 2026.0-260411 replaces GM_createFromAssemblyModel() with ModelBuilder APIs. This PR makes those changes and moves and renames the header that provides the SimModSuite version to the top level dir of the repo (apf_simConfig.h -> simModSuiteConfig.h). This is a breaking change... but I don't know if anyone will care unless they are using our header to determine which SimModSuite APIs to call etc.
A couple alternatives:
keep apf_sim/apf_simConfig.h.in and have other packages depend on it... this seems messy as gmi_sim doesn't/shouldn't depend on apf_sim
drop support for SimModSuite prior to 2023 (we support 15.0.191017 and later) and use the simmetrix SimModSuiteVersion.h header - still a breaking change, but better in the long run to not rely on our own header for the same functionality
SimModSuite 2026.0-260411 replaces GM_createFromAssemblyModel() with ModelBuilder APIs. This PR makes those changes and moves and renames the header that provides the SimModSuite version to the top level dir of the repo (apf_simConfig.h -> simModSuiteConfig.h). This is a breaking change... but I don't know if anyone will care unless they are using our header to determine which SimModSuite APIs to call etc.
Moving the file up sounds good to me. It can be a minor version bump if the apf_simConfig.h file is changed so that all it contains is #include <simModSuiteConfig.h>. Many compilers also support the #warning directive (standard since C23 [1]) that can be used to issue a deprecation notice. I suggest that the name be prefixed like other PUMI headers since neither PUMI nor Simmetrix use header subdirectories.
keep apf_sim/apf_simConfig.h.in and have other packages depend on it... this seems messy as gmi_sim doesn't/shouldn't depend on apf_sim
I agree with the logic here.
drop support for SimModSuite prior to 2023 (we support 15.0.191017 and later) and use the simmetrix SimModSuiteVersion.h header - still a breaking change, but better in the long run to not rely on our own header for the same functionality
The simModSuiteConfig.h could point to SimModSuiteVersion.h if it was found at configure time. It may also make sense to parse that file for version information instead of using the current install path heuristic. I did something similar a long time ago with the PDCurses library [2].
Thank you. pumi_ or PUMI_ prefix for the header? I'm leaning towards pumi_.
regarding use of SimModSuiteVersion.h:
To keep things simple, I'd rather just have one approach: the current extraction from the install path or directly using SimModSuiteVersion.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimModSuite 2026.0-260411 replaces
GM_createFromAssemblyModel()withModelBuilderAPIs. This PR makes those changes and moves and renames the header that provides the SimModSuite version to the top level dir of the repo (apf_simConfig.h->simModSuiteConfig.h). This is a breaking change... but I don't know if anyone will care unless they are using our header to determine which SimModSuite APIs to call etc.A couple alternatives:
apf_sim/apf_simConfig.h.inand have other packages depend on it... this seems messy as gmi_sim doesn't/shouldn't depend on apf_simSimModSuiteVersion.hheader - still a breaking change, but better in the long run to not rely on our own header for the same functionality@bobpaw Thoughts?