Fix: NPE in config api companion object#317
Merged
twisti-dev merged 2 commits intoversion/26.1from Apr 20, 2026
Merged
Conversation
- update surfConfigApi to use lazy initialization for improved performance
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the project version and adjusts how the SurfConfigApi singleton is obtained to reduce eager initialization risk.
Changes:
- Bumped project version from
3.2.2to3.2.3. - Changed
surfConfigApiinitialization to use Kotlinby lazy(defersrequiredService()until first access).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| surf-api-core/surf-api-core/src/main/kotlin/dev/slne/surf/api/core/config/SurfConfigApi.kt | Defers SurfConfigApi service lookup using lazy to reduce eager/static initialization issues. |
| gradle.properties | Increments project version to 3.2.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains a minor version update and a small improvement to how the
surfConfigApisingleton is initialized. The changes are straightforward and focus on improving initialization safety and updating the project version.Versioning:
3.2.2to3.2.3ingradle.properties.Initialization improvement:
surfConfigApito use Kotlin'sby lazydelegate, ensuring it is only created when first accessed, inSurfConfigApi.kt.