Fix #218: PackageExtension methods implemented#219
Merged
antoineatstariongroup merged 1 commit intodevelopmentfrom Apr 21, 2026
Merged
Conversation
8 tasks
samatstariongroup
requested changes
Apr 20, 2026
| throw new ArgumentNullException(nameof(packageSubject)); | ||
| } | ||
|
|
||
| if (element == null) |
Member
There was a problem hiding this comment.
should this not throw an exception, or does the spec allow this to be null?
| throw new ArgumentNullException(nameof(packageSubject)); | ||
| } | ||
|
|
||
| var importedMembership= packageSubject.ComputeImportedMembershipsOperation(excluded); |
Member
There was a problem hiding this comment.
ComputeRedefinedImportedMembershipsOperation returns the list from
ComputeImportedMembershipsOperation directly when there are no filters (line 77), but returns a fresh
.ToList() in the filtered branch (line 80). Callers mutating the return would mutate the underlying namespace
computation in one branch and not the other. Return .ToList() (or a new
List(importedMembership)) in both branches for consistent ownership semantics
antoineatstariongroup
deleted the
218-feature-implement-package-extension-methods
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Provided implementation for extension methods for the IPackage interface