Skip to content

fix: strip any host prefix from repository, not just github:#260

Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom
fix/strip-repo-host-prefix
Apr 13, 2026
Merged

fix: strip any host prefix from repository, not just github:#260
John-David Dalton (jdalton) merged 1 commit intomainfrom
fix/strip-repo-host-prefix

Conversation

@jdalton
Copy link
Copy Markdown
Collaborator

Summary

  • Repository values in external-tools.json use a <host>:owner/repo prefix convention (e.g. github:zizmorcore/zizmor)
  • Changed all .replace(/^github:/, '') calls to .replace(/^[^:]+:/, '') to handle any host prefix generically
  • Added missing prefix stripping in update.mts (was passing raw github: prefixed values to GitHub API calls)

Test plan

  • Lint passes
  • Tests pass (2184 tests)
  • Verified no hardcoded github: replace patterns remain

Repository values use a `<host>:` prefix convention (e.g. github:,
gitlab:, etc). Use `/^[^:]+:/` to strip any prefix rather than
hardcoding `github:`. Also add missing prefix stripping in update.mts.
@jdalton John-David Dalton (jdalton) merged commit 505399a into main Apr 13, 2026
14 checks passed
@jdalton John-David Dalton (jdalton) deleted the fix/strip-repo-host-prefix branch April 13, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant