fix: resolve quality scan issues#262
Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
- Fix inverted skip-build condition in publish.mjs (validated artifacts only when skipping build, not when running it) - Fix duplicate file diff reporting in release-npm-packages.mjs (missing file reported as both "missing" and "differs") - Change bcaKeysMap from Map to WeakMap in make-npm-override.mjs to allow garbage collection of browser compat data objects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skip-buildcondition inpublish.mjs— artifacts were validated only when skipping build, not when running itrelease-npm-packages.mjs— missing files reported as both "missing" and "differs" (addedelse)bcaKeysMapfromMaptoWeakMapinmake-npm-override.mjsto allow GC of browser compat data objectsTest plan