Skip to content

fix: add set -euo pipefail to provenance workflow shell steps#263

Closed
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
fix/provenance-error-handling
Closed

fix: add set -euo pipefail to provenance workflow shell steps#263
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
fix/provenance-error-handling

Conversation

@jdalton
Copy link
Copy Markdown
Collaborator

Summary

  • Add set -euo pipefail to 3 shell steps in provenance.yml: setup-script, publish-script, and access-script
  • Without this, failures in these steps are silently ignored and publishing continues with broken state

Cascade

This is a Layer 3 change. After merge:

  1. Layer 4 PR needed to update _local-not-for-reuse-provenance.yml (+ ci.yml, weekly-update) SHA pins
  2. External repos that reference provenance.yml need the propagation SHA

Test plan

  • YAML syntax valid
  • No other refs changed

Add strict error handling to setup-script, publish-script, and
access-script steps so failures are caught instead of silently
continuing to the next step.
@jdalton
Copy link
Copy Markdown
Collaborator Author

Closing — this change is unnecessary. GitHub Actions run: steps already default to bash --noprofile --norc -e -o pipefail {0}, so set -e and pipefail are already active. The only addition would be -u (treat unbound variables as errors), which risks breaking legitimate unset variable patterns and isn't worth the cascade cost.

@jdalton John-David Dalton (jdalton) deleted the fix/provenance-error-handling branch April 13, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant