fix(hooks): use strings for binary file scanning in pre-push#266
Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
Add || echo "" fallback to strings and cat command substitutions. Without this, if strings is not installed (e.g. minimal Docker/CI images), set -e silently aborts the script with exit 127, blocking the push with no message.
John-David Dalton (jdalton)
force-pushed
the
fix/hooks-strings-binary-scanning
branch
from
ae37fe2 to
9de3cfc
Compare
John-David Dalton (jdalton)
deleted the
fix/hooks-strings-binary-scanning
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stringscommand for binary files (WASM,.lockb, etc) instead of raw grep to properly detect embedded paths and secretsstrings/catcommand substitutions with|| echo ""to preventset -esilent abort ifstringsis not installed (e.g. minimal Docker/CI images)Test plan