Plugin Directory: Add unit tests for Email\Base::plugin_title()#608
Open
dd32 wants to merge 2 commits intoWordPress:trunkfrom
Open
Plugin Directory: Add unit tests for Email\Base::plugin_title()#608dd32 wants to merge 2 commits intoWordPress:trunkfrom
dd32 wants to merge 2 commits intoWordPress:trunkfrom
Conversation
Covers the entity decoding scenarios added in WordPress#606, based on real plugin titles observed in the database (®, ™, ©, numeric entities, hex entities, HTML5-only ', etc). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Avoids needing a subclass (which PHPCS flags via the "one object per file" rule) and avoids invoking the Base constructor which requires a real plugin loaded from the DB. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit tests for the
plugin_title()helper method introduced in #606.Summary
Baseconstructor (which requires DB access)Test coverage
Based on real plugin titles found in the DB:
®), trademark (™), copyright (©), degree (°)ç,ã,é, etc.)★stars)🏦building emoji)') )Test plan
WP: Plugin Directoryjob)🤖 Generated with Claude Code