fix(tck): resolve capability test failures for extensions and push notifications#804
Open
sherryfox wants to merge 1 commit intoa2aproject:0.3.x-compatfrom
Open
fix(tck): resolve capability test failures for extensions and push notifications#804sherryfox wants to merge 1 commit intoa2aproject:0.3.x-compatfrom
sherryfox wants to merge 1 commit intoa2aproject:0.3.x-compatfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates Kafka to version 4.2.0, enhances the deployment scripts with a PostgreSQL pod creation wait loop, and refactors JSON-RPC handling to improve validation and spec compliance. It introduces check() methods for request validation and a custom TypeAdapterFactory to ensure JSON-RPC 2.0 compliance for responses. Feedback was provided regarding the inconsistent validation of the mandatory jsonrpc field in streaming requests and potential precision loss when serializing numeric IDs.
…tifications - Default `extensions` to an empty list in `AgentCapabilities` to ensure it serializes as an array, fixing `test_capabilities_structure`. - Save `pushNotificationConfig` in `onMessageSend` for non-streaming messages, fixing `test_send_message_with_push_notification_config`
2c46514 to
bd65c70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extensionsto an empty list inAgentCapabilitiesto ensure it serializes as an array, fixingtest_capabilities_structure.pushNotificationConfiginonMessageSendfor non-streaming messages, fixingtest_send_message_with_push_notification_configFailures before the fixes:
After the fixes all tests are passing: