py/mkrules.mk: Allow PROG to be set on the command line for .exe targets.#39
Draft
andrewleech wants to merge 1 commit intomasterfrom
Draft
py/mkrules.mk: Allow PROG to be set on the command line for .exe targets.#39andrewleech wants to merge 1 commit intomasterfrom
andrewleech wants to merge 1 commit intomasterfrom
Conversation
…ets. When PROG is provided on the make command line (e.g. PROG=pydfu), the existing .exe-suffix rule for mingw targets has no effect because command-line variables override Makefile assignments. Use 'override' so the .exe suffix is still applied in this case. Without this, mingw builds invoked with PROG=foo produce 'foo' but the build rules still expect 'foo.exe', leading to spurious rebuilds and missing artifacts. Signed-off-by: Andrew Leech <andrew.leech@planetinnovation.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When PROG is given on the make command line (e.g.
PROG=pydfu) the existing mingw.exe-suffix rule has no effect because command-line variables override Makefile assignments. Wraps the assignment inoverrideso the suffix is still applied.Without this, mingw builds invoked with
PROG=fooproducefoobut the build rules still expectfoo.exe.Testing
Unix mingw build with and without
PROG=...; non-mingw builds (no change).