ports/windows: Allow variant override of common config defines.#44
Draft
andrewleech wants to merge 1 commit intomasterfrom
Draft
ports/windows: Allow variant override of common config defines.#44andrewleech wants to merge 1 commit intomasterfrom
andrewleech wants to merge 1 commit intomasterfrom
Conversation
Wrap most of the unconditional config defines in mpconfigport.h with #ifndef/#endif guards so that a port variant can override them via its own mpconfigvariant.h. This brings the windows port into line with what the unix port already does and is needed by minimal/specialised variants that want to disable e.g. helpers, hashlib, or json without patching the shared port config. Defaults are preserved; behaviour for the existing standard variant is unchanged. Signed-off-by: Andrew Leech <andrew.leech@planetinnovation.com.au>
andrewleech
force-pushed
the
pr/ports-windows-variant-overrides
branch
from
b7fd85c to
26c352b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wraps most of the unconditional config defines in
mpconfigport.hwith#ifndef/#endifguards so a port variant can override them via its ownmpconfigvariant.h. Brings the windows port into line with what the unix port already does. Needed by minimal/specialised variants that want to disable e.g. helpers, hashlib, json without patching the shared port config.Defaults are preserved; behaviour for the existing standard variant is unchanged.
Testing
Standard variant build (no behaviour change); a downstream variant that overrides several defines now compiles without warnings.