Skip to content

Fixed Help command being ignored#6326

Open
ArbaazKhan1 wants to merge 3 commits intoapache:mainfrom
ArbaazKhan1:accumulo-6085
Open

Fixed Help command being ignored#6326
ArbaazKhan1 wants to merge 3 commits intoapache:mainfrom
ArbaazKhan1:accumulo-6085

Conversation

@ArbaazKhan1
Copy link
Copy Markdown
Contributor

Closes issue #6085

When running --help command the launcher would fail due to main only searching Client groups when args[0] was not recognized and would fall through to execMainClassName treating the keyword as a class name.

Fixed by now searching for all non-Client groups by keyword before falling back to execMainClassName, so that legacy style invocations correctly route to BaseKeywordExecutable where --help is handled.

@dlmarion
Copy link
Copy Markdown
Contributor

I'm not sure that this is the correct change. Issue #6326 was created before I merged in my command changes that include a command group. I think the changes here would undo the command group lookup in some sense, and I'm not sure we want that.

I re-tested the issue noted in the original ticket, that accumulo info --help didn't print the help. Testing it now with accumulo inst info --help, it now prints the help. I wonder if this issue is no longer an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

accumulo command --help option not consistent

2 participants