Conversation
|
Hey, Good initiative to put some thinking around the website. My question would be why we actually need this?
|
|
Personally I prefer dark mode for pages and I always have it on by default on my system. I propose that we do this:
|
|
Most modern websites, ideally, should automatically detect and render dark/light mode based on OS preference. Many sites do this for accessibility (many people have eye issues, wherein a dark mode may be more comfortable for them). |
|
@DaanHoogland is there a way PR can create some kind of test/QA build for reviewers to see? (just wondering, if not leave it) |
|
@yadvr , we have staging for that, otherwise you can build locally and preview. |
| defaultMode: 'light', | ||
| disableSwitch: true, | ||
| disableSwitch: false, // Changed from true to false | ||
| respectPrefersColorScheme: true, |
There was a problem hiding this comment.
| respectPrefersColorScheme: true, | |
| respectPrefersColorScheme: false, |
@jbampton Let's keep it disabled for now. We can enable it later once we have polished other components which might require a change.
This is my quick attempt at adding dark mode to our website.
With the help of Gemini. Some screen shots below: