FINERACT-2585: Standardize String Locale usage in Command Infrastructure and Build Services#5758
Open
hms2186 wants to merge 1 commit intoapache:developfrom
Open
Conversation
781f5d4 to
066eaf2
Compare
Contributor
Author
|
Could a maintainer please re-run the E2E Shard 9 check? This appears to be a pre-existing flaky test unrelated to my changes — all other 42 checks are passing and the branch merges cleanly. |
8dde208 to
98da533
Compare
Contributor
Author
|
Could a maintainer please approve the CI workflows? Squashed to 1 commit as per contribution guidelines. All previous checks were passing (42/43), with only a flaky E2E Shard 9 failure unrelated to my changes. |
Contributor
Author
|
42/43 checks passing with no conflicts. The single E2E failure (Shard 15) is a pre-existing flaky test on WorkingCapitalDelinquencyConfiguration and LoanReAmortization features, unrelated to locale normalization changes. This pattern is consistent across all CI runs on this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR standardizes locale-dependent string case conversions across core command processing and build services. By replacing default .toUpperCase() calls with .toUpperCase(Locale.ROOT), we ensure consistent behavior across different deployment environments and prevent functional failures in locales with unique casing rules (e.g., the "Turkish I" issue).
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.