Skip to content

FINERACT-2585: Standardize String Locale usage in Command Infrastructure and Build Services#5758

Open
hms2186 wants to merge 1 commit intoapache:developfrom
hms2186:task/fineract-2585-standardize-locale-usage
Open

FINERACT-2585: Standardize String Locale usage in Command Infrastructure and Build Services#5758
hms2186 wants to merge 1 commit intoapache:developfrom
hms2186:task/fineract-2585-standardize-locale-usage

Conversation

@hms2186
Copy link
Copy Markdown
Contributor

@hms2186 hms2186 commented Apr 9, 2026

Description

This PR standardizes locale-dependent string case conversions across core command processing and build services. By replacing default .toUpperCase() calls with .toUpperCase(Locale.ROOT), we ensure consistent behavior across different deployment environments and prevent functional failures in locales with unique casing rules (e.g., the "Turkish I" issue).

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@hms2186 hms2186 force-pushed the task/fineract-2585-standardize-locale-usage branch from 781f5d4 to 066eaf2 Compare April 10, 2026 12:07
@hms2186
Copy link
Copy Markdown
Contributor Author

hms2186 commented Apr 14, 2026

Could a maintainer please re-run the E2E Shard 9 check? This appears to be a pre-existing flaky test unrelated to my changes — all other 42 checks are passing and the branch merges cleanly.

@hms2186 hms2186 force-pushed the task/fineract-2585-standardize-locale-usage branch from 8dde208 to 98da533 Compare April 15, 2026 08:25
@hms2186
Copy link
Copy Markdown
Contributor Author

hms2186 commented Apr 17, 2026

Could a maintainer please approve the CI workflows? Squashed to 1 commit as per contribution guidelines. All previous checks were passing (42/43), with only a flaky E2E Shard 9 failure unrelated to my changes.

@hms2186
Copy link
Copy Markdown
Contributor Author

hms2186 commented Apr 17, 2026

42/43 checks passing with no conflicts. The single E2E failure (Shard 15) is a pre-existing flaky test on WorkingCapitalDelinquencyConfiguration and LoanReAmortization features, unrelated to locale normalization changes. This pattern is consistent across all CI runs on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant