[server] Fix coordinator metrics not updated when no events arrive#3148
Open
swuferhong wants to merge 3 commits intoapache:mainfrom
Open
[server] Fix coordinator metrics not updated when no events arrive#3148swuferhong wants to merge 3 commits intoapache:mainfrom
swuferhong wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
platinumhamburg
left a comment
platinumhamburg
left a comment
There was a problem hiding this comment.
LGTM! Would you mind adding some tests for this PR?
Contributor
Author
|
@platinumhamburg comments addressed. |
wuchong
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3147
After coordinator restart, if no client requests arrive, the
CoordinatorEventThreadstays blocked onqueue.take()and neverupdates metrics gauges like activeTabletServerCount.
Fix by replacing
queue.take()withqueue.poll(timeout)so thethread periodically wakes up to refresh metrics, and initializing
lastMetricsUpdateTimeto 0 to trigger an immediate first update.Brief change log
Tests
API and Format
Documentation