[client] Ensure UPDATE_BEFORE and UPDATE_AFTER are never split across poll batches#3149
Open
loserwang1024 wants to merge 1 commit intoapache:mainfrom
Open
[client] Ensure UPDATE_BEFORE and UPDATE_AFTER are never split across poll batches#3149loserwang1024 wants to merge 1 commit intoapache:mainfrom
loserwang1024 wants to merge 1 commit intoapache:mainfrom
Conversation
… poll batches When CompletedFetch.fetchRecords() hits maxRecords, it may cut between a -U (UPDATE_BEFORE) and +U (UPDATE_AFTER) pair. If the next poll returns records from multiple buckets, downstream stateful converters (e.g., BinlogRowConverter) can see an orphaned -U whose pendingUpdateBefore state gets corrupted by interleaved records from other buckets. Fix: after the fetch loop, if the last record is UPDATE_BEFORE, fetch one additional record to include the matching UPDATE_AFTER in the same batch. Extract the per-record fetch logic into a reusable fetchRecord() method.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2880
Brief change log
When CompletedFetch.fetchRecords() hits maxRecords, it may cut between a -U (UPDATE_BEFORE) and +U (UPDATE_AFTER) pair. If the next poll returns records from multiple buckets, downstream stateful converters (e.g., BinlogRowConverter) can see an orphaned -U whose pendingUpdateBefore state gets corrupted by interleaved records from other buckets.
Fix: after the fetch loop, if the last record is UPDATE_BEFORE, fetch one additional record to include the matching UPDATE_AFTER in the same batch. Extract the per-record fetch logic into a reusable fetchRecord() method.
Tests
API and Format
Documentation