[s3] Propagate path-style-access config from server to client via delegation token#3165
Merged
polyzos merged 1 commit intoapache:release-0.9from Apr 22, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes S3-compatible storage access in delegation-token mode by ensuring the server forwards the S3A path-style addressing setting to clients (e.g., Flink TaskManagers), avoiding virtual-hosted-style DNS issues in local/Docker environments.
Changes:
- Add
fs.s3a.path.style.accessas a forwarded config key in S3 delegation tokenadditionInfos. - Introduce a constant for the new forwarded key to keep the forwarded list explicit.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
luoyuxia
force-pushed
the
fix-s3-path-style-propagation-release-0.9
branch
from
62db895 to
fda4a88
Compare
luoyuxia
changed the title
…egation token Previously, S3DelegationTokenProvider only forwarded region and endpoint to the client via additionInfos. The path.style.access setting was missing, causing the client to use virtual-hosted-style addressing (e.g., bucket.host) instead of path-style (e.g., host/bucket), which fails with S3-compatible stores like MinIO/RustFS where DNS resolution of virtual-hosted names is not available.
luoyuxia
force-pushed
the
fix-s3-path-style-propagation-release-0.9
branch
from
fda4a88 to
3fead0c
Compare
luoyuxia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
S3DelegationTokenProvideronly forwardedregionandendpointto the client viaadditionInfosin delegation tokens. Thepath.style.accesssetting was missing.bucket.host) instead of path-style (host/bucket), resulting inUnknownHostExceptionwhen using S3-compatible stores (MinIO/RustFS) in Docker environments.fs.s3a.path.style.accessto the forwarded config keys.Test plan