Skip to content

chore: update project memories with latest codebase state(1.8.0)#2998

Open
imbajin wants to merge 10 commits intomasterfrom
update-memory
Open

chore: update project memories with latest codebase state(1.8.0)#2998
imbajin wants to merge 10 commits intomasterfrom
update-memory

Conversation

@imbajin
Copy link
Copy Markdown
Member

@imbajin imbajin commented Apr 18, 2026

Purpose of the PR

Keep the project's memory clean & useful

lokidundun and others added 4 commits April 18, 2026 17:56
- Refresh all 8 memories to reflect current code (v1.7.0)
- Remove all PR number references (derivable from git history)
- Remove "Key Recent Changes" changelog section
- Remove CI implementation details (rerun delay/count)
- Describe current behavior as facts, not change events
- Mark legacy backends as excluded from Serena context
- Add GraphSpace, Swagger UI, TTL update, bridge networking info

chore: add .mcp.json to .gitignore

fix: keep .serena/memories/ and project.yml tracked in git
Copilot AI review requested due to automatic review settings April 18, 2026 20:38
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Apr 18, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates repository “project memories” / Serena configuration to reflect the current HugeGraph codebase and CI layout, plus refreshes README CI badges.

Changes:

  • Update README badges to reflect current GitHub Actions workflows.
  • Expand .serena/project.yml with richer ignore patterns and newer Serena config options.
  • Rewrite/condense multiple .serena/memories/*.md documents (commands, module map, conventions, architecture, ecosystem).

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
README.md Updates CI badges to point at server-ci.yml and pd-store-ci.yml.
.serena/project.yml Updates Serena project config: language list comments, ignore paths, and new config keys.
.serena/memories/task_completion_checklist.md Condenses checklist into a shorter “quality/tests/deps/CI/commit” format.
.serena/memories/suggested_commands.md Reorganizes common build/test/validation/docker commands into a shorter reference.
.serena/memories/project_overview.md Refreshes high-level project description, capabilities, and version summary.
.serena/memories/key_file_locations.md Updates “map” of important directories and CI workflows.
.serena/memories/implementation_patterns_and_guidelines.md Updates implementation notes (backends, GraphSpace, auth, CI, docker).
.serena/memories/ecosystem_and_related_projects.md Rewrites ecosystem overview into a compact table + integration summary.
.serena/memories/code_style_and_conventions.md Condenses style/convention notes and points to key enforcement tools.
.serena/memories/architecture_and_modules.md Simplifies architecture + module structure summary.
.gitignore Stops ignoring all of .serena/ wholesale; keeps project.yml and memories/ tracked while ignoring other .serena/*.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .serena/memories/project_overview.md
Comment thread .serena/memories/task_completion_checklist.md Outdated
Comment thread .serena/memories/suggested_commands.md
Comment thread .serena/memories/suggested_commands.md Outdated
Comment thread .serena/memories/suggested_commands.md Outdated
Comment thread .serena/project.yml Outdated
Comment thread .serena/memories/key_file_locations.md Outdated
Remove content duplicated in README.md (project overview, architecture,
module tables, code style, CI profiles). Focus test examples on active
backends (RocksDB/memory) only. Strip hardcoded version numbers. Keep
unique development workflows (dependency compliance, gRPC, auth, debugging).

262 lines → 120 lines (54% reduction, zero duplication).

refactor(docs): remove non-development sections from AGENTS.md

Remove debugging tips (ops tools), authentication system description,
Docker Compose references, and ecosystem section. 120 → 103 lines.
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Apr 18, 2026
- Remove leading blank lines in project.yml (#6)
- Clarify bin/ script path in suggested_commands.md (#4)
- Fix Docker cluster command missing cd prefix (#5)
- Add HStore to pd-store-ci.yml description (#7)
- Split editorconfig/checkstyle into separate commands (#2)
@imbajin imbajin requested a review from VGalaxies April 18, 2026 21:06
Copy link
Copy Markdown
Contributor

@VGalaxies VGalaxies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review findings from local audit.

Comment thread .serena/project.yml
Comment on lines +37 to +54
ignored_paths:
# --- Deprecated backends (focus on RocksDB/HStore only) ---
- "hugegraph-server/hugegraph-cassandra/**"
- "hugegraph-server/hugegraph-scylladb/**"
- "hugegraph-server/hugegraph-mysql/**"
- "hugegraph-server/hugegraph-postgresql/**"
- "hugegraph-server/hugegraph-palo/**"
- "hugegraph-server/hugegraph-hbase/**"
# --- gRPC generated Java (235k lines, never hand-edited, regenerated by mvn compile) ---
- "hugegraph-pd/hg-pd-grpc/src/main/java/**"
- "hugegraph-store/hg-store-grpc/src/main/java/**"
# --- License/legal files (585 txt files, only touched when adding dependencies) ---
- "install-dist/release-docs/licenses/**"
- "install-dist/scripts/dependency/known-dependencies.txt"
# --- Rarely modified tests/examples ---
- "hugegraph-server/hugegraph-test/**/tinkerpop/**"
- "hugegraph-server/hugegraph-example/**"
- "hugegraph-cluster-test/**"
Copy link
Copy Markdown
Contributor

@VGalaxies VGalaxies Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ignore list now removes HBase, cluster tests, and the dependency-compliance paths from Serena's project view. That is broader than 'dead/generated code': the repo still ships hugegraph-hbase, still runs hbase in server CI, still contains hugegraph-cluster-test, and AGENTS.md explicitly requires updating the license and known-dependencies.txt files when adding third-party dependencies. With this config, Serena-based agents will miss or be unable to complete those tasks.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ignore list now removes HBase, cluster tests, and the dependency-compliance paths from Serena's project view. That is broader than 'dead/generated code': the repo still ships hugegraph-hbase, still runs hbase in server CI, still contains hugegraph-cluster-test, and AGENTS.md explicitly requires updating the license and known-dependencies.txt files when adding third-party dependencies. With this config, Serena-based agents will miss or be unable to complete those tasks.

Yes, no need to add HBase related files as the context in the future work (from 1.8.0)

And the memory system(like serena) should focus on the main files (shouldn't include deps/license file) even they might change

Comment thread AGENTS.md
## Key Architectural Patterns

Apache HugeGraph is a fast-speed and highly-scalable graph database that supports billions of vertices and edges. It is compliant with Apache TinkerPop 3 and supports both Gremlin and Cypher query languages.
1. **Pluggable Backend Architecture**: Storage backends implement the `BackendStore` interface — new backends require no core changes. Active backends: RocksDB (default/embedded), HStore (distributed)
Copy link
Copy Markdown
Contributor

@VGalaxies VGalaxies Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condensed guide now presents RocksDB/HStore as the only active backends, which conflicts with the current tree: hugegraph-hbase is still a server module and server-ci.yml still tests the hbase backend. Agents following this summary will route HBase work away as unsupported/legacy, which is not the current project state.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condensed guide now presents RocksDB/HStore as the only active backends, which conflicts with the current tree: hugegraph-hbase is still a server module and server-ci.yml still tests the hbase backend. Agents following this summary will route HBase work away as unsupported/legacy, which is not the current project state.

Same reason, focus on the main/core backend

Comment thread AGENTS.md Outdated
imbajin added 2 commits April 19, 2026 23:36
… docs

- Add Development Conventions section: require test coverage for all code changes
- Expand Code Quality section with pre-commit checklist and .editorconfig summary
- Add Reference Documents section pointing to README and .serena/memories
- Link hugegraph-pd/store module names to their READMEs in root README

Update .gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants