SOLR-18192: Pin all GitHub Actions to full commit SHAs as per ASF policy#4288
Merged
janhoy merged 1 commit intoapache:mainfrom Apr 18, 2026
Merged
Conversation
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Solr’s GitHub Actions workflows to comply with ASF policy by pinning third-party actions to immutable full commit SHAs (instead of floating tags), reducing the risk of unexpected CI breakages from upstream tag changes.
Changes:
- Replace
uses: ...@vX(and similar floating refs) withuses: ...@<full-commit-sha>across workflows. - Add inline version comments (e.g.,
# v5.0.1) to preserve human-readable intent while keeping immutable pins. - Apply the same pinning approach to the shared composite action used by multiple workflows.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/validate-changelog.yml | Pin actions/checkout to a full commit SHA. |
| .github/workflows/stale.yml | Pin actions/stale to a full commit SHA. |
| .github/workflows/solrj-test.yml | Pin actions/checkout to a full commit SHA. |
| .github/workflows/renovate-changelog.yml | Pin actions/checkout and actions/setup-python to full commit SHAs. |
| .github/workflows/labeler.yml | Pin actions/labeler to a full commit SHA. |
| .github/workflows/gradle-precommit.yml | Pin actions/checkout to a full commit SHA. |
| .github/workflows/gradle-extraction-check.yml | Pin actions/checkout to a full commit SHA. |
| .github/workflows/docker-test.yml | Pin actions/checkout to a full commit SHA. |
| .github/workflows/docker-nightly.yml | Pin actions/checkout, actions/setup-java, actions/cache, and Docker actions to full commit SHAs. |
| .github/workflows/dependency-graph-submission.yml | Pin actions/checkout, actions/setup-java, and Gradle dependency submission action to full commit SHAs. |
| .github/workflows/bin-solr-test.yml | Pin actions/checkout and actions/upload-artifact to full commit SHAs. |
| .github/actions/prepare-for-build/action.yml | Pin actions/cache to a full commit SHA within the shared composite action. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18192
Failing jobs due to new policy: https://github.com/apache/solr/actions/workflows/docker-nightly.yml
Solved with assistance from LLM.
Dependabot or solrbot will now suggest upgrades including SHA