Skip to content

patch/misc: rtw88: fix patch rtw88 driver in 6.12.y, remove in 6.18#9652

Open
EvilOlaf wants to merge 2 commits intoarmbian:mainfrom
EvilOlaf:rtw88
Open

patch/misc: rtw88: fix patch rtw88 driver in 6.12.y, remove in 6.18#9652
EvilOlaf wants to merge 2 commits intoarmbian:mainfrom
EvilOlaf:rtw88

Conversation

@EvilOlaf
Copy link
Copy Markdown
Member

@EvilOlaf EvilOlaf commented Apr 11, 2026

Description

In 6.18.y the driver patch was never applied because there was a file name mismatch. Since the driver exists upstream in 6.13+ fixing the mismatch causing the patch to obviously fail against 6.18.y. It was removed.
Slightly different story for 6.12. Also file name mismatch, therefore the driver was never applied. I let LLM do a minor adjustment and more or less a manual patch rewrite by applying and re-extracting the changes while keeping the patch header as it is.
Thanks @MichaIng for pointing this out.

process_patch_file "${SRC}/patch/misc/rtw88/${version}/001-drivers-net-wireless-realtek-rtw88-upstream-wireless.patch" "applying"

How Has This Been Tested?

  • build sunxi legacy 6.12.80
  • no build for any 6.18 since in practical terms nothing has changed. patch has never been applied anyway.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

Release Notes

  • New Features

    • Added support for new Realtek wireless adapter chipset variants.
  • Bug Fixes

    • Updated core driver functionality for improved stability and compatibility.
    • Enhanced register mappings and low-level driver behavior for wireless transmit/receive operations.

…eam since 6.13+.

It was never applied, therefore never recognized to fail, because there was a file name mismatch.
It was never applied, therefore never recognized to fail, because there was a file name mismatch.
Due to forward moving upstream minor changes were necessary to allow clean application
@EvilOlaf EvilOlaf requested a review from pyavitz April 11, 2026 05:38
@EvilOlaf EvilOlaf requested a review from igorpecovnik as a code owner April 11, 2026 05:38
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: def3681f-6e96-4030-9a9b-3bbec79d0271

📥 Commits

Reviewing files that changed from the base of the PR and between 4cd04e6 and 9ab54bb.

📒 Files selected for processing (2)
  • patch/misc/rtw88/6.12/001-drivers-net-wireless-realtek-rtw88-upstream-wireless.patch
  • patch/misc/rtw88/6.18/001-drivers-net-realtek-rtw88-upstream-wireless.patch

📝 Walkthrough

Walkthrough

This patch extends the Realtek rtw88 wireless driver by introducing new chip/platform source files (rtw8812a, rtw8821a, rtw88xxa variants), expanding register definitions via reg.h, exporting core driver functions (rtw_download_firmware, rtw_set_trx_fifo_info), and updating header declarations for power sequencing and firmware handling across multiple driver components.

Changes

Cohort / File(s) Summary
New Chip Platform Files
drivers/net/wireless/realtek/rtw88/rtw8812a*, drivers/net/wireless/realtek/rtw88/rtw8821a*, drivers/net/wireless/realtek/rtw88/rtw88xxa*
New source files added for rtw8812a, rtw8821a, and rtw88xxa chip variants with platform-specific implementations.
Register Definitions
drivers/net/wireless/realtek/rtw88/reg.h
Expanded register/definition surface for new chip support.
Core Driver Exports
drivers/net/wireless/realtek/rtw88/mac.c
Added EXPORT_SYMBOL declarations for rtw_download_firmware and rtw_set_trx_fifo_info to expose core functions across compilation units.
Header Declarations
drivers/net/wireless/realtek/rtw88/mac.h
Added declarations for rtw_pwr_seq_parser prototype and rtw_write_firmware_page function signature.
Chip-Specific & Helper Updates
drivers/net/wireless/realtek/rtw88/...*
Updated chip-specific implementations, power sequencing, transmit/receive behavior, USB aggregation handling, register mappings, and associated constants/tables across multiple driver modules.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 A rabbit's delight for rtw88's might!
New chips now dance in wireless light,
Symbols exported, functions grow,
Let Realtek's driver steal the show!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: fixing the rtw88 patch application in 6.12.y and removing it from 6.18.y due to upstream driver availability.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added 05 Milestone: Second quarter release size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... size/large PR with 250 lines or more

Development

Successfully merging this pull request may close these issues.

1 participant