patch/misc: rtw88: fix patch rtw88 driver in 6.12.y, remove in 6.18#9652
patch/misc: rtw88: fix patch rtw88 driver in 6.12.y, remove in 6.18#9652EvilOlaf wants to merge 2 commits intoarmbian:mainfrom
Conversation
…eam since 6.13+. It was never applied, therefore never recognized to fail, because there was a file name mismatch.
It was never applied, therefore never recognized to fail, because there was a file name mismatch. Due to forward moving upstream minor changes were necessary to allow clean application
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis patch extends the Realtek rtw88 wireless driver by introducing new chip/platform source files (rtw8812a, rtw8821a, rtw88xxa variants), expanding register definitions via reg.h, exporting core driver functions (rtw_download_firmware, rtw_set_trx_fifo_info), and updating header declarations for power sequencing and firmware handling across multiple driver components. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
In 6.18.y the driver patch was never applied because there was a file name mismatch. Since the driver exists upstream in 6.13+ fixing the mismatch causing the patch to obviously fail against 6.18.y. It was removed.
Slightly different story for 6.12. Also file name mismatch, therefore the driver was never applied. I let LLM do a minor adjustment and more or less a manual patch rewrite by applying and re-extracting the changes while keeping the patch header as it is.
Thanks @MichaIng for pointing this out.
build/lib/functions/compilation/patch/drivers_network.sh
Line 411 in 4cd04e6
How Has This Been Tested?
Checklist:
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes