Fixed(issue-128): increment movesCount after successful placement#170
Open
Chiraggupta0 wants to merge 1 commit intoashishps1:mainfrom
Open
Fixed(issue-128): increment movesCount after successful placement#170Chiraggupta0 wants to merge 1 commit intoashishps1:mainfrom
Chiraggupta0 wants to merge 1 commit intoashishps1:mainfrom
Conversation
Author
|
hey @ashishps1 requesting review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #128
Summary
Fixes a bug where
Board.isFull()never returned true becausemovesCountwas never incremented.Changes
movesCountchanged from final to mutable (int).movesCount++insideplaceSymbol()after a valid placement.movesCountis initialized to 0 in constructor.How to test
mvn clean test./gradlew test(orgradlew.bat teston Windows)placeSymbol()9 times with valid coordinates.isFull()should returntrueafter 9 moves.Related Issue
Closes #<128> with actual issue if applicable -->
Notes
This is a small behavioural fix; no API changes expected.
🙏 Credits
Thanks to @subhajit100 for reporting the issue.
Requesting review from @ashishps1