fix: pin pre-commit hook --base to mirror CI#34
Merged
Conversation
Codex flagged that the Husky hook relied on fallow audit's auto-detection while CI passed --base explicitly, so a commit could clear the hook locally and still fail CI if origin/main was stale or the auto-detected ref differed. Pin to origin/main to match the CI step exactly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the fallow gate rollout. Codex flagged that the Husky pre-commit hook advertised
same semantics CI usesbut relied on fallow audit's auto-detection while CI passed--baseexplicitly. Auto-detection can pick a different ref when the tracked remote branch is stale or multiple remotes are configured, so a commit could clear the hook locally and still fail CI.Pin the hook's
--baseto match the CI step exactly.Test plan
fallow audit --base=origin/<default>and passes on this branch