langParser.js: Generate language list dynamically by mooncos · Pull Request #136 · coala/gci-leaders

mooncos · 2018-01-14T18:46:04Z

This adds langParser.js to generate the available
language list automatically from available translation
files. This also adds a npm script for generating before
webpack bundles. Modifies .gitignore so that generated
languages.js file is ignored. Adds tests. Renames
nb_NO.json to nb-NO.json to comply with RFC
standards.

Closes: #125

andrewda

Also, the rename from nb_NO to nb-NO seems unrelated to this PR.

andrewda · 2018-01-14T18:49:10Z

lib/langParser.js

+const fs = require('fs')
+const iso639 = require('iso-639-1')
+
+fs.readdir(`${__dirname}/../static/i18n`, function(err, items) {


ES6 syntax: (err, items) => {

andrewda · 2018-01-14T18:49:42Z

lib/langParser.js

+  var avaliableLanguages = {
+    Languages: {},
+  }
+  for (var i = 0; i < items.length; i++) {


items.forEach(...) is significantly cleaner in this case

andrewda · 2018-01-14T18:51:42Z

lib/langParser.js

+fs.readdir(`${__dirname}/../static/i18n`, function(err, items) {
+  var avaliableLanguages = {
+    Languages: {},
+  }


Does this need to have a nested object? Would be much cleaner to just use availableLanguages = {}

It needs to be so that we can import all nested objects at once.

andrewda · 2018-01-14T18:52:12Z

lib/langParser.js

+const iso639 = require('iso-639-1')
+
+fs.readdir(`${__dirname}/../static/i18n`, function(err, items) {
+  var avaliableLanguages = {


Typo - should be availableLanguages.

Also, use ES6's const instead of var.

andrewda · 2018-01-14T18:52:32Z

lib/langParser.js

+  for (var i = 0; i < items.length; i++) {
+    var langName = items[i].substring(0, items[i].indexOf('.'))
+    var normalizedName = langName.split('-')[0]
+    var nativeName = iso639.getNativeName(normalizedName)


All of these can be const instead of var.

andrewda · 2018-01-14T18:53:29Z

lib/langParser.js

+    `${__dirname}/../src/js/languages.js`,
+    'export default ' +
+      JSON.stringify(avaliableLanguages) +
+      ' // eslint-disable-line'


This is pretty sketch. Can we write directly to a languages.json JSON file instead?

I've tried with no success...

Is it possible to import a JSON file in ES6? I can't seem to achieve it.

mooncos · 2018-01-14T19:34:07Z

@andrewda it needs to be changed to nb-NO as per ISO and RFC standards compliance for the npm package

jayvdb · 2018-01-15T03:03:16Z

We cant rename static/i18n/nb_NO.json → static/i18n/nb-NO.json . These filenames are provided by Weblate, so we must use them otherwise they think the translation is missing.

mooncos · 2018-01-15T06:18:43Z

Ok.

blazeu · 2018-01-15T10:33:27Z

lib/langParser.js

+  })
+  fs.writeFileSync(
+    `${__dirname}/../src/js/languages.js`,
+    'export default ' +


A .json file saves the trouble of having to export things.

And how can I import a JSON file?

import name from 'file.json'

I’ve tried without success

try require() ?

blazeu · 2018-01-15T10:37:36Z

There's a webpack plugin to generate json file
https://www.npmjs.com/package/generate-json-webpack-plugin

Using that will prevent us from having another js script be added to build script.

mooncos · 2018-01-15T15:59:16Z

Ok. Should I write all logic within webpack.config.js?

blazeu · 2018-01-15T16:34:01Z

Not really, you can import/require langParser.js in webpack.config.js

mooncos · 2018-01-15T16:40:16Z

@blazeu fixed that. but where is the generated JSON located?

gitmate-bot · 2018-01-15T17:39:10Z

src/js/languages.json

@@ -0,0 +1 @@
+{"English":"en","Español":"es","Norsk bokmål":"nb_NO","język polski":"pl"}


Line contains following spacing inconsistencies:

No newline at EOF.

Origin: SpaceConsistencyBear, Section: all.whitespace.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpeolv_bln/src/js/languages.json +++ b/tmp/tmpeolv_bln/src/js/languages.json @@ -1 +1 @@ -{"English":"en","Español":"es","Norsk bokmål":"nb_NO","język polski":"pl"}+{"English":"en","Español":"es","Norsk bokmål":"nb_NO","język polski":"pl"}

Can you make this pretty printed.

Also I guess it should be in static/ , but I am not 100% sure about that.

Or .gitignore it because it's generated each time.

I fixed that but I now have another problem: webpack reads the import statements before the languages.json file is generated. I don’t know how to fix this.

elliottsj/generate-json-webpack-plugin#5

Yup it is not possible to import the generated json, might have to use the previous method or search for another webpack plugin.

webpack reads the import statements before the languages.json file is generated.

When new language is added, the compiled js will still import the file that has the old language list. That is undesirable.

This adds ``langParser.js`` to generate the available language list automatically from available translation files. This also adds a npm script for generating before webpack bundles. Modifies .gitignore so that generated ``languages.js`` file is ignored. Adds tests. Closes: coala#125

jayvdb · 2018-01-27T18:13:16Z

ack 6948c27

jayvdb · 2018-01-27T18:14:31Z

needs a rebase, and a recheck by @blazeu , or @wisn

wisn · 2018-01-28T01:22:47Z

webpack.config.js

    ]),
    new ExtractTextPlugin(`[name]${hash}.css`),
    new ManifestPlugin(),
+    new GenerateJsonPlugin('../src/js/languages.json', generatedLangList),


In case you want to prettify the output.

GenerateJsonPlugin(<file>, <json>, [replacer], [space])

Fill out that space argument.

gitmate-bot added process/pending review size/S labels Jan 14, 2018

andrewda suggested changes Jan 14, 2018

View reviewed changes

mooncos force-pushed the auto-locales branch from a5b9a69 to 8a2cd2c Compare January 14, 2018 20:04

blazeu requested changes Jan 15, 2018

View reviewed changes

mooncos force-pushed the auto-locales branch from 8a2cd2c to c8ba585 Compare January 15, 2018 17:38

gitmate-bot reviewed Jan 15, 2018

View reviewed changes

mooncos force-pushed the auto-locales branch 2 times, most recently from 8c56b9a to e2ebd2a Compare January 15, 2018 17:42

mooncos force-pushed the auto-locales branch from e2ebd2a to 6948c27 Compare January 15, 2018 17:45

gitmate-bot added the status/STALE label Jan 24, 2018

jayvdb approved these changes Jan 27, 2018

View reviewed changes

gitmate-bot added process/approved and removed status/STALE process/pending review labels Jan 27, 2018

wisn reviewed Jan 28, 2018

View reviewed changes

wisn approved these changes Jan 28, 2018

View reviewed changes

gitmate-bot added the status/STALE label Feb 5, 2018

jayvdb mentioned this pull request Mar 2, 2018

Yana Agun Siswanto - Wikimedia / Coala / Zulip gsocindonesia/coaching2018#8

Open

5 tasks

jayvdb added the process/pending review label Mar 10, 2018

jayvdb removed the process/approved label Mar 10, 2018

gitmate-bot added status/STALE and removed status/STALE labels Mar 10, 2018

jayvdb added process/wip and removed process/pending review labels May 9, 2018

gitmate-bot removed the status/STALE label May 9, 2018

gitmate-bot added the status/STALE label May 17, 2018

		@@ -0,0 +1 @@
		{"English":"en","Español":"es","Norsk bokmål":"nb_NO","język polski":"pl"} No newline at end of file

Conversation

mooncos commented Jan 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mooncos Jan 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mooncos commented Jan 14, 2018

Uh oh!

jayvdb commented Jan 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mooncos commented Jan 15, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mooncos Jan 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blazeu commented Jan 15, 2018

Uh oh!

mooncos commented Jan 15, 2018

Uh oh!

blazeu commented Jan 15, 2018

Uh oh!

mooncos commented Jan 15, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andrewda Jan 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mooncos Jan 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jayvdb commented Jan 27, 2018

Uh oh!

jayvdb commented Jan 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

mooncos commented Jan 14, 2018 •

edited

Loading

mooncos Jan 14, 2018 •

edited

Loading

jayvdb commented Jan 15, 2018 •

edited

Loading

mooncos Jan 15, 2018 •

edited

Loading

andrewda Jan 16, 2018 •

edited

Loading

mooncos Jan 16, 2018 •

edited

Loading