Skip to content

fix: process hangs when _beforeSuite helper hook throws #5515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DavertMik wants to merge 1 commit into
base: 4.x
Choose a base branch
from
+4 −0
Open

fix: process hangs when _beforeSuite helper hook throws #5515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/command/check.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ export default async function (options) {
printCheck('plugins', checks['plugins'], Object.keys(Container.plugins()).join(', '))

if (Object.keys(helpers).length) {
store.dryRun = false
const suite = Container.mocha().suite
const test = createTest('test', () => {})
checks.setup = true
Expand Down Expand Up @@ -166,6 +167,7 @@ export default async function (options) {
}

printCheck('Helpers After', checks['teardown'], standardActingHelpers.some(h => Object.keys(helpers).includes(h)) ? 'Closing browser' : '')
store.dryRun = true
}

try {
Expand Down
2 changes: 2 additions & 0 deletions lib/listener/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@ export default function () {
event.dispatcher.on(event.suite.before, suite => {
// if (suite.parent) return; // only for root suite
runAsyncHelpersHook('_beforeSuite', suite, true)
recorder.catch()
})

event.dispatcher.on(event.suite.after, suite => {
// if (suite.parent) return; // only for root suite
runAsyncHelpersHook('_afterSuite', suite, true)
recorder.catch()
})

event.dispatcher.on(event.test.started, test => {
Expand Down