make some Rust snippets more idiomatic#563
Open
moritz-gross wants to merge 1 commit intodaisy:mainfrom
Open
Conversation
NSoiffer
reviewed
Apr 23, 2026
| } else { | ||
| return Ok(value); | ||
| } | ||
| Ok(value) |
Collaborator
There was a problem hiding this comment.
I know it isn't needed, but I find adding "return" makes the code more readable to me because it makes the return value more obvious. So I prefer return Ok(value).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to keep practicing Rust some more, so I tried to find spots that could be refactored to use Rust language features a bit better.
not urgent of course, but overall I think it's good to do some housekeeping on the side.