Upgrade Protobuf versiont to 4.x.x

[siri-varma]

Description

Upgraded the Protobuf version to 4.x

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1590

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

• Code compiles correctly
• Created/updated tests
• Extended the documentation

[siri-varma]

Integration tests are failing due to flaky test #1603

[siri-varma]

@dapr/approvers-java-sdk / @dapr/maintainers-java-sdk PR ready for review. Thank you

Update Protobof version to 4.33.2 (latest)

[salaboy]

@siri-varma I am worried about doing this, because we the grpc netty libraries also depend on Protobuf. As far as I remember we upgraded to the version that was aligned with Spring Boot and the versions used by the Spring Boot Otel instrumentation that also uses GRPC. I wouldn't upgrade this unless we are also upgrading those dependencies. Can you check which dependencies depend on protobuf by running mvn dependency:tree

[salaboy]

I don't think I can approve this unless we check which transitive dependencies also depend on this.

[siri-varma]

Hello @javier-aliaga ! Just wanted to check with you on this. Thank you.

[siri-varma]

Hello @javier-aliaga ! Just wanted to bump this up again

[lindner]

protobuf v3 --> v4 is difficult as mixing them can cause problems for consumers of the library too.

[siri-varma]

@lindner Thank you for the comment.

We don't expose protos to the library users. They are only used inside the SDK.
If you don't mind could you suggest some scenarios where it can cause problems ? I can try adding some tests.

[siri-varma]

@javier-aliaga Thoughts on this PR ?

[javier-aliaga]

@siri-varma I think we should go with it , we just need to align all version and check transitive deps. Btw, there are no file changes in the PR, probably go lost in any of your changes

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.76%. Comparing base (4ec9b89) to head (12ced92).

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1611   +/-   ##
=========================================
  Coverage     76.76%   76.76%           
  Complexity     2260     2260           
=========================================
  Files           241      241           
  Lines          7066     7066           
  Branches        740      740           
=========================================
  Hits           5424     5424           
  Misses         1279     1279           
  Partials        363      363           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.