Skip to content

Define segmentation when it is first mentioned#364

Open
jni wants to merge 1 commit intodatacarpentry:mainfrom
jni:define-segmentation
Open

Define segmentation when it is first mentioned#364
jni wants to merge 1 commit intodatacarpentry:mainfrom
jni:define-segmentation

Conversation

@jni
Copy link
Copy Markdown

@jni jni commented Apr 19, 2026

While reading this lesson, I noticed that segmentation was used but not clearly defined.
I think a simple definition will help learners understand what they are working towards.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 19, 2026

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-364

The following changes were observed in the rendered markdown documents:

 07-thresholding.md | 3 ++-
 md5sum.txt         | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2026-04-21 07:53:26 +0000

Copy link
Copy Markdown
Contributor

@K-Meech K-Meech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jni ! I agree - a clearer definition of segmentation would be great to start this lesson.

I've made some very minor suggestions on wording below. @marcodallavecchia / @uschille - would be good if you could also take a quick look.

Comment on lines +29 to +30
which is the partitioning of an image into disjoint regions, or *segments*.
The different segments can then be analyzed separately.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
which is the partitioning of an image into disjoint regions, or *segments*.
The different segments can then be analyzed separately.
where an image is split into different regions, or *segments*.
These segments can then be analyzed separately.

I feel like the words 'partitioning' and 'disjoint' may not be familiar to all learners? How about using 'split' / 'different' as simpler terms?

where we change the pixels of an image to make the image easier to analyze.
which is the partitioning of an image into disjoint regions, or *segments*.
The different segments can then be analyzed separately.
In thresholding, we convert an image from colour or grayscale into
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably good to add a blank line above 'In thresholding...' to start a new paragraph. Makes this section easier to read in the rendered docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants