Define segmentation when it is first mentioned#364
Define segmentation when it is first mentioned#364jni wants to merge 1 commit intodatacarpentry:mainfrom
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-364 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2026-04-21 07:53:26 +0000 |
K-Meech
left a comment
There was a problem hiding this comment.
Thanks for the contribution @jni ! I agree - a clearer definition of segmentation would be great to start this lesson.
I've made some very minor suggestions on wording below. @marcodallavecchia / @uschille - would be good if you could also take a quick look.
| which is the partitioning of an image into disjoint regions, or *segments*. | ||
| The different segments can then be analyzed separately. |
There was a problem hiding this comment.
| which is the partitioning of an image into disjoint regions, or *segments*. | |
| The different segments can then be analyzed separately. | |
| where an image is split into different regions, or *segments*. | |
| These segments can then be analyzed separately. |
I feel like the words 'partitioning' and 'disjoint' may not be familiar to all learners? How about using 'split' / 'different' as simpler terms?
| where we change the pixels of an image to make the image easier to analyze. | ||
| which is the partitioning of an image into disjoint regions, or *segments*. | ||
| The different segments can then be analyzed separately. | ||
| In thresholding, we convert an image from colour or grayscale into |
There was a problem hiding this comment.
Probably good to add a blank line above 'In thresholding...' to start a new paragraph. Makes this section easier to read in the rendered docs.
While reading this lesson, I noticed that segmentation was used but not clearly defined.
I think a simple definition will help learners understand what they are working towards.