Skip to content

feat: implement new skeleton loader structure and remove unused code #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kulikp1 wants to merge 2 commits into
base: next
Choose a base branch
from
Open

feat: implement new skeleton loader structure and remove unused code #566

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b49670
feat: implement new skeleton loader structure and remove unused code
kulikp1 Apr 17, 2026
d77238a
Merge branch 'next' into feature/AdminForth/1404/you've-made-new-load…
kulikp1 Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 12 additions & 52 deletions adminforth/spa/src/views/CreateEditSkeleton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div class="w-full mt-[36px]">
<div class="w-full border dark:border-darkFormBorder border-gray-200 rounded-lg overflow-hidden shadow-resourseFormShadow dark:shadow-darkResourseFormShadow bg-white dark:bg-darkForm">

<div class="flex px-6 items-center border-b border-gray-200 dark:border-darkFormBorder bg-lightFormHeading dark:bg-darkFormHeading" style="height: 40px;">
<div class="flex px-6 items-center border-b border-gray-200 dark:border-darkFormBorder bg-lightFormHeading dark:bg-darkFormHeading h-[40px]">
<div class="w-[208px] flex-shrink-0 pr-6 text-xs text-lightListTableHeadingText uppercase dark:text-darkListTableHeadingText font-bold">
{{ $t('Field') }}
</div>
Expand All @@ -11,64 +11,24 @@
</div>
</div>

<template v-for="column in visibleColumns" :key="column.name">
<div
class="flex items-center bg-lightForm dark:bg-darkForm border-b border-gray-100 dark:border-darkFormBorder"
:style="{ height: getFieldHeight(column) }"
>
<div class="w-[208px] flex-shrink-0 px-6 flex items-center">
<Skeleton class="w-24 h-[10px]" />
</div>

<div class="flex-1 px-6">
<Skeleton type="input" :class="getSkeletonInputClass(column)" />
<div
v-for="i in 10"
:key="i"
class="flex items-center bg-lightForm dark:bg-darkForm border-b border-gray-100 dark:border-darkFormBorder h-[75px]"
>
<div class="w-[208px] flex-shrink-0 px-6 flex items-center">
<Skeleton class="w-24 h-[10px]" />
</div>

<div v-if="hasEditingNote(column)" class="mt-1">
<Skeleton class="h-[12px] w-20" />
</div>
</div>
<div class="flex-1 px-6">
<Skeleton class="h-[10px] w-full" />
</div>
</div>

</template>
</div>
</div>
</template>

<script setup lang="ts">
import { computed } from 'vue';
import { Skeleton } from '@/afcl';

interface Props {
resource?: any;
page?: string;}

const props = withDefaults(defineProps<Props>(), {
page: 'edit'
});

const visibleColumns = computed(() => {
if (!props.resource?.columns) return [];

return props.resource.columns.filter((col: any) => {
if (col.virtual) return false;
if (col.primaryKey) return false;
if (col.backendOnly) return false;
if (col.showIn?.[props.page] === false) return false;
return true;
});
});


const hasEditingNote = (column: any) => !!column.editingNote;

const getFieldHeight = (column: any) =>
hasEditingNote(column) ? '95px' : '75px';

const getSkeletonInputClass = (column: any) => {
if (['integer', 'decimal', 'float'].includes(column.type)) {
return 'h-[42px] w-[160px]';
}
return 'h-[42px] w-full';
};

</script>