Open
Conversation
pjsph
force-pushed
the
fix/ogg-stereo-decoding
branch
from
8666c91 to
74d8ffc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example was only working with mono audio files, despite the visible effort to make it work with both mono and stereo.
Field
nsamplesof andspWaveBufactually represents the number of samples for one channel (as in L/R channels) only. When reading a stereo file, previous code was telling the dsp that it had to read twice more samples than were stored in the buffer, which resulted in audio being chopped (played for 120ms, the length of the buffer, then cut for 120ms), and surely a UB