push up all_zeros_expr and all_ones_expr helpers to bitvector_typet#8963
Open
push up all_zeros_expr and all_ones_expr helpers to bitvector_typet#8963
all_zeros_expr and all_ones_expr helpers to bitvector_typet#8963Conversation
This moves the class bitvector_typet from std_types.h into bitvector_types.h, which is more intuitive.
This pushes up the two helper methods all_zeros_expr and all_ones_expr from bv_typet to bitvector_typet, as it is often desirable to create all-zeros and all-ones constants for the other bitvector types as well.
c536d69 to
765bc4c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8963 +/- ##
========================================
Coverage 80.49% 80.50%
========================================
Files 1704 1704
Lines 188805 188804 -1
Branches 73 73
========================================
+ Hits 151983 151989 +6
+ Misses 36822 36815 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
peterschrammel
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pushes up the two helper methods
all_zeros_exprandall_ones_exprfrombv_typettobitvector_typet, as it is often desirable to create all-zeros and all-ones constants for the other bitvector types as well.