Skip to content

push up all_zeros_expr and all_ones_expr helpers to bitvector_typet#8963

Open
kroening wants to merge 2 commits intodevelopfrom
bitvector_typet_all
Open

push up all_zeros_expr and all_ones_expr helpers to bitvector_typet#8963
kroening wants to merge 2 commits intodevelopfrom
bitvector_typet_all

Conversation

@kroening
Copy link
Copy Markdown
Collaborator

This pushes up the two helper methods all_zeros_expr and all_ones_expr from bv_typet to bitvector_typet, as it is often desirable to create all-zeros and all-ones constants for the other bitvector types as well.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This moves the class bitvector_typet from std_types.h into
bitvector_types.h, which is more intuitive.
This pushes up the two helper methods all_zeros_expr and all_ones_expr from
bv_typet to bitvector_typet, as it is often desirable to create all-zeros
and all-ones constants for the other bitvector types as well.
@kroening kroening force-pushed the bitvector_typet_all branch from c536d69 to 765bc4c Compare April 19, 2026 18:13
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.50%. Comparing base (0656298) to head (765bc4c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8963   +/-   ##
========================================
  Coverage    80.49%   80.50%           
========================================
  Files         1704     1704           
  Lines       188805   188804    -1     
  Branches        73       73           
========================================
+ Hits        151983   151989    +6     
+ Misses       36822    36815    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants