Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions .agents/skills/code-check/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,6 @@ Examples:
- `just clippy` - lint all code
- `just clippy -- -D warnings` - treat warnings as errors

### Check Shell Scripts
```bash
just check-sh
```
Lints shell scripts. Currently checks the `install` script.

**Requirements**: Requires `shellcheck` to be installed. The command will provide installation instructions if not available.

## Important Guidelines

### MANDATORY: Run Checks After Changes
Expand All @@ -65,13 +57,6 @@ Before considering a task complete: all checks MUST pass AND all clippy warnings
- If warnings → fix ALL → return to step 2
5. Repeat until: zero compilation errors AND zero clippy warnings

**Shell script (install script):**
1. Edit the `install` script
2. Format: use `/code-format` skill (run `just fmt-sh`)
3. **Check shellcheck**: `just check-sh`
- If warnings → fix ALL → return to step 2
4. Repeat until: zero shellcheck warnings

## Common Mistakes to Avoid

### ❌ Anti-patterns
Expand Down
6 changes: 0 additions & 6 deletions .agents/skills/code-format/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,6 @@ This is a critical requirement from the project's development workflow:
2. When ready to validate, run: `just fmt-rs`
3. Then run checks

**Shell script edit:**
1. Edit the `install` script
2. When ready to validate, run: `just fmt-sh`
3. Then run checks

## Common Mistakes to Avoid

### ❌ Anti-patterns
Expand All @@ -114,7 +109,6 @@ This is a critical requirement from the project's development workflow:
- Format before running checks/tests or before committing
- Use `just fmt-rs-file` for 1-2 files (faster, targeted)
- Use `just fmt-rs` for 3+ files (more efficient)
- Use `just fmt-sh` after editing the `install` script
- Run format check commands to verify formatting before commits

## Next Steps
Expand Down
2 changes: 1 addition & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ trim_trailing_whitespace = true
indent_size = 2

# Tabs required for <<-EOF heredoc indent stripping
[{*.sh,install}]
[{*.sh}]
indent_style = tab
shell_variant = bash
binary_next_line = true
Expand Down
1 change: 0 additions & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,6 @@ For more detailed information about the project:
- `rust-toolchain.toml` — Pins Rust 1.92.0
- `rustfmt.toml` — Formatting config (nightly features)
- `justfile` — Task runner commands
- `install` — Platform-agnostic installer script (root level)

### Documentation

Expand Down
90 changes: 0 additions & 90 deletions install

This file was deleted.

74 changes: 0 additions & 74 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,55 +33,6 @@ fmt-rs-check:
fmt-rs-file FILE:
cargo +nightly fmt -- {{FILE}}

# Format shell scripts (shfmt)
[group: 'format']
fmt-sh:
#!/usr/bin/env bash
set -e # Exit on error

# Check if shfmt is installed
if ! command -v "shfmt" &> /dev/null; then
>&2 echo "=============================================================="
>&2 echo "Required command 'shfmt' not available"
>&2 echo ""
>&2 echo "Please install shfmt using your preferred package manager:"
>&2 echo " brew install shfmt"
>&2 echo " apt-get install shfmt"
>&2 echo " pacman -S shfmt"
>&2 echo " go install mvdan.cc/sh/v3/cmd/shfmt@latest"
>&2 echo ""
>&2 echo "See: https://github.com/mvdan/sh"
>&2 echo "=============================================================="
exit 1
fi

shfmt --write install

# Check shell scripts format (shfmt --diff)
[group: 'format']
fmt-sh-check:
#!/usr/bin/env bash
set -e # Exit on error

# Check if shfmt is installed
if ! command -v "shfmt" &> /dev/null; then
>&2 echo "=============================================================="
>&2 echo "Required command 'shfmt' not available"
>&2 echo ""
>&2 echo "Please install shfmt using your preferred package manager:"
>&2 echo " brew install shfmt"
>&2 echo " apt-get install shfmt"
>&2 echo " pacman -S shfmt"
>&2 echo " go install mvdan.cc/sh/v3/cmd/shfmt@latest"
>&2 echo ""
>&2 echo "See: https://github.com/mvdan/sh"
>&2 echo "=============================================================="
exit 1
fi

shfmt --diff install


## Check

alias check := check-rs
Expand All @@ -96,31 +47,6 @@ check-rs *EXTRA_FLAGS:
clippy *EXTRA_FLAGS:
cargo clippy --all-targets {{EXTRA_FLAGS}}

# Lint shell scripts (shellcheck)
[group: 'check']
check-sh:
#!/usr/bin/env bash
set -e # Exit on error

# Check if shellcheck is installed
if ! command -v "shellcheck" &> /dev/null; then
>&2 echo "=============================================================="
>&2 echo "Required command 'shellcheck' not available"
>&2 echo ""
>&2 echo "Please install shellcheck using your preferred package manager:"
>&2 echo " brew install shellcheck"
>&2 echo " apt-get install shellcheck"
>&2 echo " dnf install ShellCheck"
>&2 echo " pacman -S shellcheck"
>&2 echo ""
>&2 echo "See: https://github.com/koalaman/shellcheck"
>&2 echo "=============================================================="
exit 1
fi

shellcheck -x -o all -S style install


## Build

alias build := build-ampup
Expand Down
Loading