Skip to content

fix(tck): resolve capability test failures for extensions and push notifications #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sherryfox wants to merge 1 commit into
base: 0.3-workflows
Choose a base branch
from
Open

fix(tck): resolve capability test failures for extensions and push notifications #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions server-common/src/main/java/io/a2a/server/requesthandlers/DefaultRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,13 @@ public EventKind onMessageSend(MessageSendParams params, ServerCallContext conte
}
}
}
if (kind instanceof Task taskResult && !taskId.equals(taskResult.getId())) {
throw new InternalError("Task ID mismatch in agent response");
if (kind instanceof Task taskResult) {
if (shouldAddPushInfo(params)) {
pushConfigStore.setInfo(taskResult.getId(), params.configuration().pushNotificationConfig());
}
if (taskId != null && !taskId.equals(taskResult.getId())) {
throw new InternalError("Task ID mismatch in agent response");
}
}

// Send push notification after initial return (for both blocking and non-blocking)
Expand Down
4 changes: 4 additions & 0 deletions spec/src/main/java/io/a2a/spec/AgentCapabilities.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
public record AgentCapabilities(boolean streaming, boolean pushNotifications, boolean stateTransitionHistory,
List<AgentExtension> extensions) {

public AgentCapabilities {
extensions = extensions == null ? List.of() : extensions;
}

public static class Builder {

private boolean streaming;
Expand Down