build(deps): bump spamoor to pick up go-ethereum glamsterdam-devnet-0#160
Open
barnabasbusa wants to merge 5 commits intomasterfrom
Open
build(deps): bump spamoor to pick up go-ethereum glamsterdam-devnet-0#160barnabasbusa wants to merge 5 commits intomasterfrom
barnabasbusa wants to merge 5 commits intomasterfrom
Conversation
Pulls in ethpandaops/spamoor#216 which bumps go-ethereum to the glamsterdam-devnet-0 branch. The new geth txpool enforces `tx.Gas() >= ceil(intrinsicGas * 10/9)` when `gasCostPerStateByte != 0`, so spamoor's funding and scenario gas limits needed to rise above the 21000 floor to stop every transfer being rejected with "intrinsic gas too low: gas 21000, minimum needed 21000".
barnabasbusa
added
the
build-docker-image
Pulls ethpandaops/spamoor@5ecd3bd, which replaces the hardcoded 21000 funding gas with an eth_estimateGas-based resolver + 20% headroom plus retry-on-intrinsic-gas-too-low. Fixes the funding-tx rejection hit on glamsterdam-devnet-0 where geth enforces a 110% admission margin.
barnabasbusa
force-pushed
the
bbusa/bump-spamoor-glamsterdam
branch
from
4c9dbc1 to
a50e22b
Compare
barnabasbusa
force-pushed
the
bbusa/bump-spamoor-glamsterdam
branch
from
a50e22b to
c93c531
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/ethpandaops/spamoorto the HEAD of spamoor#216, which tracksgo-ethereumon theglamsterdam-devnet-0branch.go-ethereumto commit499762852c, matching theethpandaops/geth:glamsterdam-devnet-0image currently used in GLOAS devnets.Motivation
Running the
gloas-dev/builder-lifecycle.yamlplaybook against aglamsterdam-devnet-0enclave fails immediately ingenerate_child_walletwith:The new geth txpool adds a rule in
core/txpool/validation.gothat requirestx.Gas() >= ceil(intrinsicGas * 10/9)whenevergasCostPerStateByte != 0. For a plain transfer that is 23334 gas, but spamoor's funding/scenario path hardcoded 21000. The error message confusingly printsintrGas.RegularGas(21000) as "minimum needed" instead of the scaled value, which is what you see above.spamoor#216 raises the affected gas limits so funding and scenario txs clear the new floor. This PR just pulls that fix into assertoor.
Test plan
go mod tidymake buildgo test ./...gloas-dev/builder-lifecycle.yamlagainst aglamsterdam-devnet-0enclave and confirmgenerate_child_walletsucceeds (blocked on spamoor#216 merging; happy to re-verify after)