Skip to content

chore: bump apps to v1.1.1#3275

Merged
julienrbrt merged 1 commit intomainfrom
julien/bump-apps
Apr 22, 2026
Merged

chore: bump apps to v1.1.1#3275
julienrbrt merged 1 commit intomainfrom
julien/bump-apps

Conversation

@julienrbrt
Copy link
Copy Markdown
Member

@julienrbrt julienrbrt commented Apr 22, 2026

Overview

Summary by CodeRabbit

  • Chores
    • Updated core dependency to v1.1.1 across multiple modules.
    • Removed local development path overrides to use released versions.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7d6c531f-b4a3-4df0-95fb-7499f11ccb5a

📥 Commits

Reviewing files that changed from the base of the PR and between 36a7f15 and ab0e616.

⛔ Files ignored due to path filters (3)
  • apps/evm/go.sum is excluded by !**/*.sum
  • apps/grpc/go.sum is excluded by !**/*.sum
  • apps/testapp/go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • apps/evm/go.mod
  • apps/grpc/go.mod
  • apps/testapp/go.mod

📝 Walkthrough

Walkthrough

The PR comments out local module replace directives across three Go module files (apps/evm, apps/grpc, apps/testapp) and upgrades the github.com/evstack/ev-node dependency from v1.1.0 to v1.1.1 in each module.

Changes

Cohort / File(s) Summary
Dependency Version Bump and Local Replace Removal
apps/evm/go.mod, apps/grpc/go.mod, apps/testapp/go.mod
Commented out local replace directives for github.com/evstack/ev-node modules (disabling path-based overrides) and bumped github.com/evstack/ev-node from v1.1.0 to v1.1.1 in the require section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • tac0turtle
  • chatton

Poem

🐰 twitches nose with glee
Replace directives bundled tight,
Now local paths fade from sight,
V-one-one-one hops into place,
A cleaner build, a nimbler pace! 🚀

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely empty, containing only the unmodified template boilerplate with no actual context, explanation, or rationale provided. Add an Overview section explaining why the version bump is necessary, what changes it includes, and any relevant context or issue references.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: bumping dependency versions across multiple app modules from v1.1.0 to v1.1.1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch julien/bump-apps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 22, 2026

Claude finished @julienrbrt's task in 53s —— View job


Code Review

  • Gather context and read changed files
  • Analyze dependency changes
  • Provide review feedback

This is a straightforward dependency bump across the three app modules (evm, grpc, testapp), upgrading github.com/evstack/ev-node from v1.1.0v1.1.1. The go.sum entries are consistent and correctly generated.

One observation worth addressing:

Commented-out replace directives

All three go.mod files convert active replace directives into comments rather than removing them:

// replace (
// 	github.com/evstack/ev-node => ../../
// 	github.com/evstack/ev-node/execution/evm => ../../execution/evm
// )

This pattern is unconventional. go.mod directives are either active or absent — commented-out lines carry no semantic meaning to the toolchain but create noise and could confuse contributors about whether they should be re-enabled. The v1.1.0 entries in go.sum are also still present but no longer referenced, which is harmless but adds residual clutter.

Recommended approach: If local development requires pointing to the monorepo root, use a go.work / go.work.sum file (which is .gitignored by convention) instead of committed replace directives. This keeps go.mod files clean and release-ready without requiring edits for each release cycle. Fix this →

Everything else looks good

  • Version bump is consistent across all three modules ✓
  • go.sum hashes for v1.1.1 are identical across modules (same content hash h1:J9h5PKx177XdvNWLZCDOkWJEGRIrPzYxkCFhbGkVUm8=) ✓
  • Previously replace-masked transitive entries (execution/evm v1.0.1, execution/grpc v1.0.0-rc.1) are now properly recorded in go.sum
  • No functional code changes — purely a chore/release bump ✓

The PR is approved pending cleanup of the commented-out replace blocks (or an explanation of why they're being preserved this way).

@github-actions
Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedApr 22, 2026, 10:54 AM

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.82%. Comparing base (36a7f15) to head (ab0e616).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3275      +/-   ##
==========================================
+ Coverage   61.80%   61.82%   +0.02%     
==========================================
  Files         122      122              
  Lines       16241    16241              
==========================================
+ Hits        10037    10041       +4     
+ Misses       5317     5314       -3     
+ Partials      887      886       -1     
Flag Coverage Δ
combined 61.82% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julienrbrt julienrbrt enabled auto-merge April 22, 2026 11:03
@julienrbrt julienrbrt disabled auto-merge April 22, 2026 12:13
@julienrbrt julienrbrt merged commit 49b40f0 into main Apr 22, 2026
53 of 54 checks passed
@julienrbrt julienrbrt deleted the julien/bump-apps branch April 22, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants