Fix loading .json.gz profiles from inside zip archives#5959
Merged
canova merged 1 commit intofirefox-devtools:mainfrom Apr 21, 2026
Merged
Fix loading .json.gz profiles from inside zip archives#5959canova merged 1 commit intofirefox-devtools:mainfrom
canova merged 1 commit intofirefox-devtools:mainfrom
Conversation
When clicking a .json.gz entry in a zip file, viewProfileFromZip called
file.async('string'), which decoded the gzip bytes as UTF-8 and
corrupted the stream before unserializeProfileOfArbitraryFormat could
detect the gzip magic and decompress. Switching to 'uint8array' keeps
the content binary so the existing isGzip/decompress path runs. Plain
.json entries still work via the Uint8Array to TextDecoder fallback.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5959 +/- ##
==========================================
- Coverage 85.37% 85.33% -0.04%
==========================================
Files 322 322
Lines 32069 32117 +48
Branches 8814 8827 +13
==========================================
+ Hits 27378 27408 +30
- Misses 4260 4278 +18
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #5958.
When clicking a .json.gz entry in a zip file,
viewProfileFromZipcalledfile.async('string'), which decoded the gzip bytes as UTF-8 and corrupted the stream beforeunserializeProfileOfArbitraryFormatcould detect the gzip magic and decompress. Switching to'uint8array'keeps the content binary so the existingisGzip/decompresspath runs. Plain .json entries still work via the Uint8Array to TextDecoder fallback.Example profile