Skip to content

Support WLED repos other than the official AirCoookie #1576

Closed
netmindz wants to merge 3 commits intofrenck:mainfrom
netmindz:repo
Closed

Support WLED repos other than the official AirCoookie #1576
netmindz wants to merge 3 commits intofrenck:mainfrom
netmindz:repo

Conversation

@netmindz
Copy link
Copy Markdown
Contributor

@netmindz netmindz commented Dec 8, 2024

If you have devices running builds from your own fork or WLED-MM (MoonModules) then you should be able to configure the WLED add-on in HomeAssistant to check this repo for the source of your updates, rather than hard-coded to Aircoookie/WLED

Ideally, it should look on a per-device basis to see where its release came from, but this might require some changes to WLED to present this through the API and not just as the badge on the manual OTA page - I still need to investigate this and that might be for later PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 8, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@frenck
Copy link
Copy Markdown
Owner

frenck commented Dec 9, 2024

Sorry, I have no intention of support any of the WLED forks. There are too many variants out there, and above all, it will create a nightmare supporting all the tiny differences between versions and APIs.

../Frenck

@frenck frenck closed this Dec 9, 2024
@netmindz
Copy link
Copy Markdown
Contributor Author

netmindz commented Dec 9, 2024

Adding support for looking at a different GitHub repo isn't the same as trying to support true forks that might have different APIs for WLED.

MoonModules has API compatibility with WLED-AC

@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
@frenck
Copy link
Copy Markdown
Owner

frenck commented Apr 16, 2026

Reopening — the idea of configurable repo for updates/releases is worth pursuing, especially now that WLED has moved to the wled org. The implementation needs a clean rewrite to fit the current codebase (remove print statements, commented-out code, and properly type the new parameters).

@frenck frenck reopened this Apr 16, 2026
@frenck frenck added the new-feature New features or options. label Apr 16, 2026
@frenck
Copy link
Copy Markdown
Owner

frenck commented Apr 16, 2026

Superseded by #2039

@frenck frenck closed this Apr 16, 2026
@netmindz netmindz deleted the repo branch April 17, 2026 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

new-feature New features or options.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants