fix(build): Fix build on FreeBSD.#13269
Draft
yonas wants to merge 1 commit intogitbutlerapp:masterfrom
Draft
Conversation
|
@yonas is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
Comment on lines
-232
to
+234
| "apple-native", | ||
| "windows-native", | ||
| "linux-native-sync-persistent", | ||
| "crypto-rust", | ||
| "sync-secret-service", | ||
|
|
Contributor
There was a problem hiding this comment.
Could you please explain this change in feature flags. Why are we removing the other os' native keyring options?
Author
There was a problem hiding this comment.
Yeah, this change made the compilation work but isn't portable. Let me think about it.
Byron
requested changes
Apr 11, 2026
Collaborator
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
I set it back to draft and make the change-request from the comments official, as we definitely can't merge it in its current form and have to think about merging it at all without CI support.
It's too easy to regress in future otherwise, so I'd make CI support a requirement for a merge as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧢 Changes
🎫 Affected issues
Fixes: #13268