[GHSA-h383-gmxw-35v2] The Log4j1XmlLayout from the Apache Log4j 1-to-Log4j 2...

[ppkarwasz]

Updates

• Affected products
• CVSS v4
• Description
• Source code location
• Summary

Comments
Improve formatting and component identity based on:

• VDR
• Security page

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the GHSA advisory content for GHSA-h383-gmxw-35v2 to improve accuracy/formatting and better identify the affected component and versions, incorporating updated CVSSv4 and reference information.

Changes:

• Adds a clearer summary and reformats details (inline code, bullet list, note block).
• Replaces the CVSS v4 vector with a shorter base-metrics-only vector.
• Populates affected with Maven package/version ranges and adds an extra reference.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The NOTE blockquote/admonition formatting is inconsistent: the line with the migration guide link is not part of the blockquote, so the “NOTE” may render oddly depending on the markdown renderer. If you want this to be a single note, prefix the link line with "> " (or avoid the GitHub-specific "[!NOTE]" admonition syntax and use plain text that renders consistently across consumers).

Suggested change

"details": "The `Log4j1XmlLayout` from the Apache Log4j 1-to-Log4j 2 bridge fails to escape characters forbidden by the XML 1.0 standard, producing malformed XML output. Conforming XML parsers are required to reject documents containing such characters with a fatal error, which may cause downstream log processing systems to drop or fail to index affected records.\n\nTwo groups of users are affected:\n\n* Those using `Log4j1XmlLayout` directly in a Log4j Core 2 configuration file.\n* Those using the Log4j 1 configuration compatibility layer with `org.apache.log4j.xml.XMLLayout` specified as the layout class.\n\nUsers are advised to upgrade to Apache Log4j 1-to-Log4j 2 bridge version `2.25.4`, which corrects this issue.\n\n> [!NOTE]\n> The Apache Log4j 1-to-Log4j 2 bridge is deprecated and will not be present in Log4j 3. Users are encouraged to consult the\n[Log4j 1 to Log4j 2 migration guide](https://logging.apache.org/log4j/2.x/migrate-from-log4j1.html), and specifically the section on eliminating reliance on the bridge.",

"details": "The `Log4j1XmlLayout` from the Apache Log4j 1-to-Log4j 2 bridge fails to escape characters forbidden by the XML 1.0 standard, producing malformed XML output. Conforming XML parsers are required to reject documents containing such characters with a fatal error, which may cause downstream log processing systems to drop or fail to index affected records.\n\nTwo groups of users are affected:\n\n* Those using `Log4j1XmlLayout` directly in a Log4j Core 2 configuration file.\n* Those using the Log4j 1 configuration compatibility layer with `org.apache.log4j.xml.XMLLayout` specified as the layout class.\n\nUsers are advised to upgrade to Apache Log4j 1-to-Log4j 2 bridge version `2.25.4`, which corrects this issue.\n\n> [!NOTE]\n> The Apache Log4j 1-to-Log4j 2 bridge is deprecated and will not be present in Log4j 3. Users are encouraged to consult the\n> [Log4j 1 to Log4j 2 migration guide](https://logging.apache.org/log4j/2.x/migrate-from-log4j1.html), and specifically the section on eliminating reliance on the bridge.",

[ppkarwasz]

The suggestion sounds reasonable and should probably be merged (I don't have permission to do it).