AddLinearModel and CompactLinearModel class objects along with introduction of fitlm and stepwiselm#424
Open
Pasta-coder wants to merge 26 commits intognu-octave:mainfrom
Open
AddLinearModel and CompactLinearModel class objects along with introduction of fitlm and stepwiselm#424Pasta-coder wants to merge 26 commits intognu-octave:mainfrom
LinearModel and CompactLinearModel class objects along with introduction of fitlm and stepwiselm#424Pasta-coder wants to merge 26 commits intognu-octave:mainfrom
Conversation
…es + code style fixes
…and QR enhancements
Added an explicit check in to throw a fatal error when passed an empty array, matching MATLAB's standard behavior. This prevents the silent propagation of empty variables into dependent architectures.
Added explicit validation to match MATLAB parity. dummyvar now correctly throws a dimension error for non-column categorical variables, preventing the silent collapse of the design matrix. It also correctly rejects raw cell arrays to prevent unintended dynamic type conversions.
- Throw error when formula references unrecognized variable names (F1.4.5) - Route DummyVarCoding NV pair through fitlm pipeline to design builder - Implement 'full' dummy coding (all levels, no reference drop) for categoricals (F1.4.6) - Default remains 'reference' coding for backward compatibility
- Convert Coefficients property from struct to table with RowNames (F2.1.2) - Create LinearFormula class with clean disp for Formula encapsulation (F2.1.6) - Update CompactLinearModel disp/predict to handle LinearFormula objects - Fix addTerms/removeTerms dimension mismatch when Terms matrix includes response column
- Implement table-to-design-matrix conversion in predict with categorical dummy expansion - Only extract predictor columns active in the model via InModel flag - Add feval method as predict alias (MATLAB parity) - Add feval dispatch in subsref
LinearModel and CompactLinearModel class objects along with introduction of fitlm and stepwiselm
LinearModel and CompactLinearModel class objects along with introduction of fitlm and stepwiselmLinearModel and CompactLinearModel class objects along with introduction of fitlm and stepwiselm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a major overhaul and implementation
LinearModelandCompactLinearModelclass objects along with introduction offitlm. it also introducesstepwiselmbut it's unusable .textinfos , demos , BISTs are added but are not sufficient (as per statistics package convention)
related to #266 . (if not mergeable then it can definitely be used as a reference pr)
few successful manual tests are (while the entire testsuite against which i am testing can be found in the file final_test.md) -