Skip to content

chore(managed-identities): rm unused config API path#12856

Open
zhumin8 wants to merge 4 commits intomainfrom
rm-managed-identities-v1beta1
Open

chore(managed-identities): rm unused config API path#12856
zhumin8 wants to merge 4 commits intomainfrom
rm-managed-identities-v1beta1

Conversation

@zhumin8
Copy link
Copy Markdown
Contributor

@zhumin8 zhumin8 commented Apr 20, 2026 •
edited
Loading

Removing unused API path from config for managed-identities, so that it matches the generated code status.

v1beta1 of java-managed-identities was added to the generation_config.yaml as part of initial migration to hermetic build: 14b7346, but client library code for v1beta1 is not present in java-managed-identities/google-cloud-managed-identities dir. This is due to deep-copy-regex being too strict and does not copy /v1beta1 from staging dir to final output.

Expect generation workflow to remove sample code related to v1beta1.

For #12736
For googleapis/librarian#5370

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the v1beta1 proto path for the Managed Identities API from the generation configuration. I have no feedback to provide.

@zhumin8
Copy link
Copy Markdown
Contributor Author

zhumin8 commented Apr 20, 2026

hmm, we got no changed libraries

+ changed_libraries=
+ echo 'Changed libraries are: No changed library.'
Changed libraries are: No changed library.

@zhumin8 zhumin8 mentioned this pull request Apr 21, 2026
Closed
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 21, 2026

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zhumin8
Copy link
Copy Markdown
Contributor Author

zhumin8 commented Apr 21, 2026

Forced a code generation for this library by a temp change (3e4f22a)
Generated sample code under this dir are removed as expected: java-managed-identities/samples/snippets/generated/com/google/cloud/managedidentities/v1beta1

reverted above temp change.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 21, 2026

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zhumin8 zhumin8 marked this pull request as ready for review April 21, 2026 19:23
@zhumin8 zhumin8 requested a review from a team as a code owner April 21, 2026 19:23
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Apr 21, 2026

Here is the summary of changes.

You are about to delete 53 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@zhumin8 zhumin8 requested a review from blakeli0 April 21, 2026 19:23
@zhumin8 zhumin8 enabled auto-merge (squash) April 21, 2026 19:23
@zhumin8
Copy link
Copy Markdown
Contributor Author

zhumin8 commented Apr 22, 2026

@blakeli0 PTAL.
The removed files are sample code within
java-managed-identities/samples/snippets/generated/com/google/cloud/managedidentities/v1beta1/ I think it's reasonable to remove since the relevant code for v1beta1 does not exists and samples are not published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 Awaiting requested review from blakeli0

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhumin8 @cloud-java-bot