fix(gax): Remove strict validation that resize delta must be less than max channel count#12863
Merged
fix(gax): Remove strict validation that resize delta must be less than max channel count#12863
Conversation
This reverts commit 91ffb52.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable maxResizeDelta to the ChannelPoolSettings and implements a mechanism to log a warning when the channel pool undergoes repeated resizing cycles. It also includes several bug fixes related to channel count clamping and improves the internal logic for determining when a resize is necessary. The review feedback identifies a validation check for maxResizeDelta that is overly restrictive and could cause failures in valid configurations, such as small pools. Additionally, there is a concern regarding the thread safety of the consecutiveResizes counter, which is currently a primitive integer accessed outside of synchronized blocks.
jinseopkim0
reviewed
Apr 20, 2026
…unds # Conflicts: # sdk-platform-java/gax-java/gax-grpc/src/test/java/com/google/api/gax/grpc/ChannelPoolTest.java
# Conflicts: # sdk-platform-java/gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/ChannelPoolSettings.java # sdk-platform-java/gax-java/gax-grpc/src/test/java/com/google/api/gax/grpc/ChannelPoolTest.java
…y static pool config # Conflicts: # sdk-platform-java/gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/ChannelPoolSettings.java # sdk-platform-java/gax-java/gax-grpc/src/test/java/com/google/api/gax/grpc/ChannelPoolTest.java
…y static pool config
lqiu96
force-pushed
the
fix/channelpool-logic-fix
branch
from
cc0cb9b to
1c205e3
Compare
lqiu96
changed the title
jinseopkim0
reviewed
Apr 22, 2026
lqiu96
changed the title
lqiu96
commented
Apr 22, 2026
blakeli0
reviewed
Apr 22, 2026
lqiu96
changed the title
|
|
lqiu96
changed the title
jinseopkim0
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address some comments in #12838
It is possible that users use the DEFAULT_RESIZE_DELTA (2) with a statically sized channel pool (1). We should not enforce that the resize delta needs to be less than or equal to the channel pool. Instead, the channel pool's tentative target is calculated to be clamped within the channelpoolsetting's configured bounds.