chore(spanner): accomodate experimental host in samples#12876
chore(spanner): accomodate experimental host in samples#12876Adarsh-Shrivastava-001 wants to merge 2 commits intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the libraries-bom version to 26.79.0 and modifies several Spanner sample snippets to incorporate ExperimentalHostHelper for handling experimental host configurations. Additionally, it updates the main class reference in the pom.xml and adds a missing import in MutableCredentialsExample.java. I have no feedback to provide.
|
Here is the summary of changes. You are about to add 1 region tag.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
| <archive> | ||
| <index>false</index> | ||
| <manifest> | ||
| <mainClass>com.example.spanner.admin.archived.SpannerSample</mainClass> |
There was a problem hiding this comment.
I don't think this change is intentional?
There was a problem hiding this comment.
This change is intentional as we want to pick the newer version the mentioned class. Do you see any problems with this?
| import java.util.concurrent.ScheduledExecutorService; | ||
| import java.util.concurrent.ThreadFactory; | ||
| import java.util.concurrent.TimeUnit; | ||
| import java.util.concurrent.atomic.AtomicReference; |
There was a problem hiding this comment.
Yes, else this cause compilation failure. essentially its missing is current version of code.
rahul2393
left a comment
rahul2393
left a comment
There was a problem hiding this comment.
Samples are snippets which customer can copy-paste as it is and run in there application, We should not be using testing helper methods here, also can you please share the use-case of these sample changes are they going to land on docs.cloud.google.com?
…update import references
I have created a new helper class and migrated required methods with proper error handling to examples package. Regarding the use case and docs, that will be a followup as discussed. |
olavloite
added
the
do not merge
3 participants
Add the support for experimental host in sample command.