fix(spanner): always prefer leader for strong reads and retries should only check EWMA score#12879
Open
fix(spanner): always prefer leader for strong reads and retries should only check EWMA score#12879
Conversation
…d only check EWMA score
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the tablet selection logic in KeyRangeCache.java to ensure that the leader is prioritized during initial requests when preferLeader is set, while falling back to score-aware selection for retries or when the leader is excluded. Feedback indicates that the call to selectScoreAwareTablet should explicitly disable leader bias during retries to strictly follow performance-based selection. New test cases were added to validate these scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.