chore: fix spanner fallback and add test for split_release_note#12896
Open
chore: fix spanner fallback and add test for split_release_note#12896
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the module detection logic in split_release_note.py to implement a fallback for retrieving API names from .repo-metadata.json and introduces a new unit test for this functionality. Feedback highlights a likely AttributeError due to an inconsistent attribute rename and recommends a file existence check to avoid a FileNotFoundError during metadata retrieval.
meltsufin
force-pushed
the
fix/changelog-script-spanner
branch
from
925ee78 to
723cbcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code assumed that if
.OwlBot-hermetic.yamlexisted, it must contain anapi-name. This is not true for Spanner, which has the file but lacks theapi-name field. So, fallback to.repo-metadata.jsonis needed sometimes even if.OwlBot-hermetic.yamlexists.Towards #12864.